Export BuildID via expvars. #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,7 @@ import ( | |||
| "encoding/json" | |||
| "encoding/pem" | |||
| "errors" | |||
| "expvar" | |||
There was a problem hiding this comment.
So, packages using core will get /debug/vars by virtue of this import.
Maybe we should be explicit about importing expvar in cmd where we set up the other debug handlers?
It'd be a _ "expvar" import there.
|
LGTM but that one small additional import in |
|
AMQP Timeout here. I'm into how much more common they are becoming. Think we might have pushed these things far enough that we can repro them reliably enough to actually debug them in TravisCI. |
|
r=jcjones |
|
r=jcjones (re-r) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1188