-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow AMQP URLs to be loaded from files. #1205
Conversation
@@ -127,7 +127,7 @@ | |||
"maxContactsPerRegistration": 100, | |||
"debugAddr": "localhost:8002", | |||
"amqp": { | |||
"server": "amqp://guest:guest@localhost:5673", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave one of these as the old style so that it breaks if the code is broken in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
LGTM |
Conflicts need to be fixed. |
This allows secret values to be separated from the main config. Part of #1157
Fixed conflicts. |
LGTM |
Allow AMQP URLs to be loaded from files.
This allows secret values to be separated from the main config.
Part of #1157