wfe: allow POST-as-GET to dir. and newNonce endpoints #292
Conversation
RFC 8555 §6.3[0] says the server's `directory` and `newNonce` endpoints should support POST-as-GET as well as GET. This commit adopts a fix from eggsampler's Pebble fork[1]. Thanks! [0]: https://tools.ietf.org/html/rfc8555#section-6.3 [1]: eggsampler@ce1b722
There was a problem hiding this comment.
There's a weird high-level thing: Since you have to fetch the directory before you can create an account, it's impossible to POST-as-GET the directory, since you don't have an account URL yet. In practice this probably means no client will implement POST-as-GET for the directory, since the client minimally needs support for GETting the directory and there's no reason to switch over to POST-as-GET for subsequent runs. But I think it's still good to comply with the letter of the spec here.
Agreed, but the spec says what it says. All of the POST-as-GET stuff is jank and this is just another weird artifact of changing the spec with minimal input at the very end of the process. ¯\_(ツ)_/¯ |
RFC 8555 §6.3 says the server's
directoryandnewNonceendpoints should support POST-as-GET as well as GET.This PR adopts a fix from eggsampler's Pebble fork. Thanks @eggsampler !
Along the way to avoid the ire of the linter I replaced the numerous occurrences of "GET", "POST", and "HEAD" with the correct exported
httppackage constants.Resolves #291