Orders don't have a "deactivated" status. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "invalid" instead, and add comments linking to the spec.
|
👋 FWIW Boulder has the same divergence: https://github.com/letsencrypt/boulder/blob/9a86abc1550425a73f912c25a11c29160f58a85a/sa/sa.go#L1218-L1221 |
|
I think I managed to still trigger this. I need to do a few more tests to make sure i'm running the right code - I'm not very good with |
|
Ok, thanks so much for testing! If you need any help, let me know. |
Zola-github
previously approved these changes
Feb 28, 2020
|
I finally got a chance to test. This works as expected from the RFC. |
Co-authored-by: Samantha <hello@entropy.cat>
Co-authored-by: Samantha <hello@entropy.cat>
…e into orders-not-deactivated
aarongable
approved these changes
May 6, 2022
beautifulentropy
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "invalid" instead, and add comments linking to the spec.
Fixes #300