-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard shortcuts #4
Comments
Hello @AntouanK. I can look into adding keyboard shortcuts. Would the following be okay?
👍 |
Sure. Or if you want to be compatible and not think about it, maybe follow VLC?
And one thing I would add is subtitles control so you can change them or disable/enable them. There is no way to control them anyway, right?
Hopefully if the commits you make for those are simple enough, I can try to add some more later :) |
Hello @lettier,
Could that be possible? |
Hello @airabinovich, Yes that is possible. I will go ahead and add those shortcuts. 👍 |
Hello @airabinovich, I have added the left and right seek keyboard shortcuts to version 0.0.3.0. 👍 |
@lettier did you look at all if cycling/toggling the subtitles is possible? If you can point me to where to look at, I might have a go at it myself during the holidays. :) |
Hello @AntouanK, I have subtitle management working in a local branch. Figuring out the best way to keep it simple. 🤔 Besides disabling or cycling through the (possibly) included subtitle streams, would you also like the ability to load a SRT file and have that override any current subtitle stream? 👍 |
I guess the priority should be what most users need. Another thing I might do sometimes, is change the font. But that's a nice to have I guess. |
Hello @AntouanK, I have updated master with subtitle support. 👍 |
Hello @AntouanK, Thank you for trying out the subtitle feature. What is the output of the following command? gst-discover-1.0 /path/to/The.Simpsons.S29E09.Gone.Boy.1080p.AMZN.WEB-DL.DD+5.1.H.264-SiGMA.mkv | grep -i language These files are known to work. Could you try playing one of them? You can use the latest AppImage if you like. One has known subtitle streams while the other has unknown subtitle streams. gst-discoverer-1.0 -v Sintel_DivXPlus_6500kbps.mkv | grep -i language
language code: zh
Language: zh
language code: ja
Language: ja
language code: pt
Language: pt
language code: nl
Language: nl
language code: fr
Language: fr
language code: es
Language: es
language code: de
Language: de
language code: en
Language: en
language code: en
Language: en
language code: en
Language: en
language code: en
language code: de gst-discoverer-1.0 -v ElephantsDream_DivXHD1080p_ASP.divx | grep -i language
Language: <unknown>
Language: <unknown>
Language: <unknown>
Language: <unknown>
Language: <unknown>
Language: <unknown>
Language: <unknown>
Language: <unknown>
Language: <unknown> Unless burned in, the subtitles should never show now unless requested, regardless of any available subtitle streams, since subtitles are disabled at the start of each video. So even though the selection box doesn't show in your screenshot, the subtitle shown should not be there. 👍 |
This is the whole output from
It only has english subtitles. And most "web-rip" videos I've seen, are like that. I tried the video you mentioned, and again I get no option. |
Hello @AntouanK, To access the recent subtitle feature, you'll need to build from source using the master branch or you can try the AppImage here. The AUR is only at version 0.0.3.0. To see what version you're using, click on the about button. If building from source, you'll want to make sure that your local master branch is up to date with the remote master branch. The current pre-release, 0.0.4.0, didn't have subtitle support for a few commits. So if the about dialog says, 0.0.4.0, you'll have to pull from master and rebuild. cd movie-monad
git checkout master
git reset --hard origin/master
git pull
# If you have `stack`
make
make run 👍 |
Hello @AntouanK, Thank you for testing and for the error report. I'll keep an eye on it. I'll go ahead and release version 0.0.4.0. 👍 |
Do any keyboard shortcuts exist?
If not, can we add any?
Maybe
space
to pause/play and something for audio volume and mute?The text was updated successfully, but these errors were encountered: