Add BigDecimal compatibility for ruby 2.6

[bobmaerten]

Filter string to pass on to Bigdecimal in to_multiplier method to
prevent errors like:

ArgumentError: invalid value for BigDecimal()

[czj]

Only macOS fails with Ruby 2.6.0-rc1

[bobmaerten]

Tiens on se demandait pourquoi Travis fait 2 build sur chaque PR, mais en fait c'est écrit dans le détail. Pour une PR, il passe les tests sur la branche de la PR, et il simule un merge de la branche vers sa cible pour passer les tests dessus.

Malin.... Très malin !

Branch

This is a normal build for the prepare_for_ruby_2.6 branch. You should be able to reproduce it by checking out the branch locally.

PR

This is a pull request build.

It is running a build against the merge commit, after merging #13 Add BigDecimal compatibility for ruby 2.6.
Any changes that have been made to the master branch before the build ran are also included.

[bobmaerten]

Chez moi ça marche ™️ en ruby 2.6.0-rc1

~/Work/fuel_surcharge prepare_for_ruby_2.6*
❯ ruby -v
ruby 2.6.0rc1 (2018-12-06 trunk 66253) [x86_64-darwin18]

~/Work/fuel_surcharge prepare_for_ruby_2.6*
❯ rake
/Users/bob/.rbenv/versions/2.6.0-rc1/lib/ruby/gems/2.6.0/gems/addressable-2.5.2/lib/addressable/idna/pure.rb:154: warning: assigned but unused variable - startercc
Run options: --seed 46359

# Running:

..............

Finished in 4.450880s, 3.1454 runs/s, 15.9519 assertions/s.

14 runs, 71 assertions, 0 failures, 0 errors, 0 skips

[czj]

Weird. Ruby 2.6 is still in RC, gems and CIs have not caught up yep. We can merge like this, then :)

[czj]

Indeed, a very, very clever and safe approach to merging ! Travis CI really is the best :o