This repository has been archived by the owner on Jan 2, 2020. It is now read-only.
Adapt FuelSurcharge::TNT to TNT's website changes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use TNT instead of Tnt or TnTTest
Handles the possibility of 2 instead of 3 months with percentages in the page. Allows debugging response by having a separate method.
We use &. in many places in the class, why not using them everywhere ?
The build broke when we reached "décembre" with an accent, because Date.parse() cannot parse a string with an accent. By asserting presence of french months' in text string, the tests are more reliable. Also use the instance variable @tnt like in ever other method in the test class.
|
Ca manque de mise à jour du changelog... Notamment sur le changement de syntaxe de |
|
I’m not familiar with the process :)
Teach me !
|
|
see #6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles "décembre" as the month name via more reliable tests.