Skip to content
This repository has been archived by the owner on Jan 2, 2020. It is now read-only.

Optimize chronopost scrapping #42

Merged
merged 6 commits into from
Mar 18, 2019
Merged

Optimize chronopost scrapping #42

merged 6 commits into from
Mar 18, 2019

Conversation

bobmaerten
Copy link
Collaborator

@bobmaerten bobmaerten commented Mar 18, 2019 •
edited
Loading

StringScanner FTW.

houndci-bot
houndci-bot reviewed Mar 18, 2019
View reviewed changes
lib/fuel_surcharge/string_formatter.rb Show resolved Hide resolved
lib/fuel_surcharge/string_formatter.rb Outdated Show resolved Hide resolved
lib/fuel_surcharge/html_scanner.rb Outdated Show resolved Hide resolved
lib/fuel_surcharge/html_scanner.rb Outdated Show resolved Hide resolved
lib/fuel_surcharge/html_scanner.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
@bobmaerten bobmaerten changed the title Imize chronopost scrapping Optimize chronopost scrapping Mar 18, 2019
@bobmaerten
Copy link
Collaborator Author

Il m'embête Hound la :)

@bobmaerten bobmaerten requested a review from czj March 18, 2019 14:37
@bobmaerten bobmaerten assigned bobmaerten and unassigned bobmaerten Mar 18, 2019
houndci-bot
houndci-bot reviewed Mar 18, 2019
View reviewed changes
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
lib/fuel_surcharge/chronopost.rb Show resolved Hide resolved
@czj
Copy link
Contributor

czj commented Mar 18, 2019

C'était un essai du service, on peut se concentrer sur Sider je pense :)

@bobmaerten
Copy link
Collaborator Author

Faudrait trouver un service qui supporte(rait) standard aussi du coup, ou trouver comment faire en sorte d'exporter les règles des la gem.

@czj
Copy link
Contributor

czj commented Mar 18, 2019

Je pense que Sider ne tardera pas à adopter standard.rb puisqu'ils utilisent déjà une configuration de Rubocop.

On part là dessus, je viens de les activer.

@czj
Copy link
Contributor

czj commented Mar 18, 2019

Il va peut-être falloir réfléchir à une alternative à Travis CI aussi, hélas.

@levups levups deleted a comment Mar 18, 2019
@bobmaerten
Copy link
Collaborator Author

On pourrait se "contenter" d'une action Github qui passerait les tests ici

@czj
Copy link
Contributor

czj commented Mar 18, 2019

Sider open source = 💯 🆗 😃

czj added 3 commits March 19, 2019 00:03
@czj
Merge branch 'master' into optimize_chronopost_scrapping
b4dda5e 
* master:
  Add Sider config file
  Add standard.rb config file
  Update rubocop.yml to inherit from standardrb
  Fix Colissimo live test for next month being publish ahead of time
  Run standard:fix rake tasks
  Add standard rake tasks
  Replace rubocop config with standard rb one
  Bump rubocop from 0.65.0 to 0.66.0
@czj
Ensure Chronopost sample HTML file is read as UTF-8
26170b3 
The file must be read as UTF-8 to match Chronopost's website encoding.
Fixes flaky tests in the process.
@czj
End Ruby 2.3 support
2b10d6c 
Sorry to those stuck in this old version.

Support ends in april 2019
RefugeRestrooms/refugerestrooms#523
@czj czj merged commit 7592a11 into master Mar 18, 2019
@czj czj deleted the optimize_chronopost_scrapping branch March 18, 2019 23:17
@czj
Copy link
Contributor

czj commented Mar 18, 2019

I need a written procedure to deploy a new version of the gem.
Procedure in this repo, of that I'll write myself ... I have forgotten how to do it, again :-(

@bobmaerten
Copy link
Collaborator Author

bobmaerten commented Mar 19, 2019 •
edited
Loading

Quick reminder before writing a complete guide, or updating the Action workflow to proceed to automatic release upon "release" event:

  • make a PR for the release
  • bump version in lib/fuel_surcharge/version.rb
  • run git fetch --all --prune --tag to ensure having latest tags
  • update CHANGELOG.md file by running rake changelog
  • commit and push
  • merge PR to automatically publish a new release
  • draft and validate a new release on https://github.com/levups/fuel_surcharge/releases/new with content added to CHANGELOG for instance

@czj
Copy link
Contributor

czj commented Mar 20, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@czj czj Awaiting requested review from czj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobmaerten @czj @houndci-bot