add single pendle oracle #2
Conversation
| /// @custom:security-contact security@euler.xyz | ||
| /// @author Euler Labs (https://www.eulerlabs.com/) | ||
| /// @notice Adapter for Pendle PT and LP Oracle. | ||
| contract PendleAllInOneOracle is BaseAdapter, Ownable2Step { |
There was a problem hiding this comment.
This naming seems clumsy to me, I'd suggest PendleUnifiedOracle or something
| /// @return The converted amount using the Pendle oracle. | ||
| function _getQuote(uint256 inAmount, address _base, address _quote) internal view override returns (uint256) { | ||
| PairParams memory pairParams = _configuredPairs[_base][_quote]; | ||
| if (pairParams.base == address(0) || pairParams.quote == address(0)) { |
There was a problem hiding this comment.
You can remove one of those: if pairParams.base != address(0) then it's guarantied pairParams.quote != address(0)
| pairParams.scale = ScaleUtils.calcScale(0, 0, FEED_DECIMALS); | ||
|
|
||
| _configuredPairs[_base][_quote] = pairParams; | ||
| _configuredPairs[_quote][_base] = pairParams; |
There was a problem hiding this comment.
Params resettings must be forbidden
| /// @notice The address of the base asset, the PT address. | ||
| address base; | ||
| /// @notice The address of the quote asset, the SY or underlying address. | ||
| address quote; |
There was a problem hiding this comment.
A gas optimization is possible here by saving some storage: the addresses are already required for fetching this struct from storage, you only need to figure out, which of those is base and quote respectively. So you can store something like
bool baseLessThanQuote = base < quote;and then use it as
(address base, address quote) =
params.baseLessThanQuote == (_base < _quote) ? (_base, _quote) : (_quote, _base);
bool inverse = ScaleUtils.getDirectionOrRevert(_base, base, _quote, quote);| address pendleMarket, | ||
| uint32 twapWindow, | ||
| address base, | ||
| address quote, |
There was a problem hiding this comment.
If you decide to implement my last suggestion, I'd actually not changed this output format, since it's more convenient from human perspective
No description provided.