Flx faces have no underline under theme sanityinc-tomorrow-night

[goofansu]

No description provided.

[lewang]

That hasn't changed. Can you check that your version of flx-ido is the same as on master branch?

[oscarfv]

flx just defines a face that inherits from another one. Current theme
can redefine flx-highlight-face. It's not flx's fault that your theme
effectively removes the underline attribute from flx-highlight-face.

Here, with solarized-dark theme, no underscores are shown. As soon as I
disable the theme they appear again.

[bbatsov]

@goofansu This has nothing to do with flx - it's related to the theme you're using. I guess @purcell doesn't like the underlines - I've also removed them from zenburn and solarized.

@lewang I guess you should close this issue.

[purcell]

Agreed, that was my choice. But in fact someone submitted a fix for the faces yesterday and I've merged them, so if you grab the latest Tomorrow themes package from MELPA, the flx highlight face should be yellow and bold. (But still no underline!)

[goofansu]

@purcell
@bbatsov

Thank you for the reply

Kind Regards,

goofansu

在 2013年7月28日星期日，上午2:01，Steve Purcell 写道：

Agreed, that was my choice. But in fact someone submitted a fix for the faces yesterday and I've merged them, so if you grab the latest Tomorrow themes package from MELPA, the flx highlight face should be yellow and bold. (But still no underline!)

—
Reply to this email directly or view it on GitHub (#32 (comment)).