chore: contribution generation #8
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| @@ -33,26 +33,37 @@ | |||
| "contributes": { | |||
| "iconThemes": [ | |||
| { | |||
| "id": "glyph.legacy", | |||
| "id": "glyph.legacy-original", | |||
There was a problem hiding this comment.
hmmm, idk how vscode is going to handle the updating of this. maybe keep it the same or look into how backwards compat works for existing users
| }, | ||
| { | ||
| "id": "glyph.minimal", | ||
| "id": "glyph.legacy-minimal", |
| "build": "npm-run-all -s build:*" | ||
| }, | ||
| "dependencies": { | ||
| "lodash": "^4" |
There was a problem hiding this comment.
maybe this shouldn't be a devDep instead of a dep (for now). The implementation for commands/settings isn't there yet. No need to bloat it
tsconfig.json
Outdated
There was a problem hiding this comment.
I want to figure out if we can use more modern (readable?) compilation while still keeping things simple
src/utils/types/index.d.ts
Outdated
There was a problem hiding this comment.
Not sure if the use of declaration (.d.ts) files are the right choice here. Perhaps implicit global types through the tsconfig? But maybe that's too complicated idk
|
migrated most changes to a more manageable stacked PR |
No description provided.