bug #976 Fix authentication with integer as useridentifier (Florian G…

…uedon) This PR was merged into the 2.x branch. Discussion ---------- Fix authentication with integer as useridentifier Fix authentication with integer as useridentifier caused argument type error with UserBadge (Maybe only with Symfony >= 6.0) Commits ------- 8b722db Fix authentication with integer as useridentifier caused argument type error with UserBadge
lexik · Jan 27, 2022 · ada31e7 · ada31e7
2 parents 6a196f3 + 8b722db
commit ada31e7
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/Security/Authenticator/JWTAuthenticator.php b/Security/Authenticator/JWTAuthenticator.php
@@ -123,7 +123,7 @@ public function doAuthenticate(Request $request) /*: Passport */
         }
 
         $passport = new SelfValidatingPassport(
-            new UserBadge($payload[$idClaim],
+            new UserBadge((string)$payload[$idClaim],
             function ($userIdentifier) use($payload) {
                 return $this->loadUser($payload, $userIdentifier);
             })

diff --git a/Tests/Security/Authenticator/JWTAuthenticatorTest.php b/Tests/Security/Authenticator/JWTAuthenticatorTest.php
@@ -70,6 +70,35 @@ public function testAuthenticate() {
         $this->assertSame($userStub, ($authenticator->authenticate($this->getRequestMock()))->getUser());
     }
 
+    public function testAuthenticateWithIntegerIdentifier() {
+        $userIdClaim = 'sub';
+        $payload = [$userIdClaim => 1];
+        $rawToken = 'token';
+        $userRoles = ['ROLE_USER'];
+
+        $userStub = new AdvancedUserStub(1, 'password', 'user@gmail.com', $userRoles);
+
+        $jwtManager = $this->getJWTManagerMock(null, $userIdClaim);
+        $jwtManager
+            ->method('parse')
+            ->willReturn(['sub' => 1]);
+
+        $userProvider = $this->getUserProviderMock();
+        $userProvider
+            ->method('loadUserByIdentifierAndPayload')
+            ->with($payload['sub'], $payload)
+            ->willReturn($userStub);
+
+        $authenticator = new JWTAuthenticator(
+            $jwtManager,
+            $this->getEventDispatcherMock(),
+            $this->getTokenExtractorMock($rawToken),
+            $userProvider
+        );
+
+        $this->assertSame($userStub, ($authenticator->authenticate($this->getRequestMock()))->getUser());
+    }
+
     public function testAuthenticateWithExpiredTokenThrowsException() {
         $jwtManager = $this->getJWTManagerMock();
         $jwtManager->method('parse')