fix: apply changes from code review (argument injection)

lexik · Dec 20, 2020 · dfa4861 · dfa4861
1 parent 2857c68
commit dfa4861
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/DependencyInjection/LexikJWTAuthenticationExtension.php b/DependencyInjection/LexikJWTAuthenticationExtension.php
@@ -121,6 +121,12 @@ public function load(array $configs, ContainerBuilder $container)
                 ->getDefinition('lexik_jwt_authentication.handler.authentication_success')
                 ->replaceArgument(2, new IteratorArgument($cookieProviders));
         }
+
+        $container
+            ->getDefinition('lexik_jwt_authentication.generate_keypair_command')
+            ->replaceArgument(1, $config['secret_key'])
+            ->replaceArgument(2, $config['public_key'])
+            ->replaceArgument(3, $config['pass_phrase']);
     }
 
     private static function createTokenExtractors(ContainerBuilder $container, array $tokenExtractorsConfig)

diff --git a/Resources/config/console.xml b/Resources/config/console.xml
@@ -19,9 +19,9 @@
 
         <service id="lexik_jwt_authentication.generate_keypair_command" class="Lexik\Bundle\JWTAuthenticationBundle\Command\GenerateKeyPairCommand">
             <argument type="service" id="filesystem" />
-            <argument type="string">%env(default::resolve:JWT_SECRET_KEY)%</argument>
-            <argument type="string">%env(default::resolve:JWT_PUBLIC_KEY)%</argument>
-            <argument type="string">%env(default::JWT_PASSPHRASE)%</argument>
+            <argument />
+            <argument />
+            <argument />
             <tag name="console.command" command="lexik:jwt:generate-keypair" />
         </service>
     </services>