Switch to single binary, and some makefile cleanup #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2020
|
Thanks @deitch -- we'll look. |
|
Great. I will hit those right away. |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
|
All updated. |
|
Looks great, thanks a lot @deitch! |
|
We need @rvs to pull it in. I have merge rights on Adam, not lf-edge org in general. |
|
Hey @deitch you can now merge changes into the repo as well. I need to setup a proper committer file to add everybody else on the team tho |
|
Thanks @rvs |
mydatascience
added a commit
that referenced
this pull request
Feb 5, 2021
* # This is a combination of 7 commits. # This is the 1st commit message: Added setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #2: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #3: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #4: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #5: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #6: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #7: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> * Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> * Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> * Fix setup action Signed-off-by: fleandr <svfly@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1
This PR does a few things:
dist/bin/eden-<os>-<arch>so we can cross-build with ease./eden