Refactoring for networkInstanceTest. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
Signed-off-by: Oleg Sadov <oleg.sadov@gmail.com>
|
Hey @sadov -- in general we prefer smaller, self-contained PRs. For example, this one has Makefile logic changes mingled together with changes to the tests, it also seems to contain various stylistic changes (like changing the case of a variable name from upper to lower). In the future, please make sure to split these types of commits into individual PRs, ok? This time -- I'll merge it as-is. |
|
OK -- we will try to reduce the size of our PR. |
mydatascience
added a commit
that referenced
this pull request
Feb 5, 2021
* # This is a combination of 7 commits. # This is the 1st commit message: Added setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #2: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #3: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #4: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #5: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #6: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> # This is the commit message #7: Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> * Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> * Fix setup action Signed-off-by: fleandr <svfly@yandex.ru> * Fix setup action Signed-off-by: fleandr <svfly@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that all 3 types (switch/L2, local, cloud) of the networks can be successfully deployed to an EVE instance.