Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor running unit tests #121

Closed
rvs opened this issue Jun 30, 2019 · 3 comments
Closed

Refactor running unit tests #121

rvs opened this issue Jun 30, 2019 · 3 comments

Comments

@rvs
Copy link
Contributor

rvs commented Jun 30, 2019

Unit tests need to be put into a separate check in the circle pipeline and we also need to make sure make test target returns non-0 exit code if tests fail
@dave-tucker
Copy link
Contributor

dave-tucker commented Nov 16, 2019 •
edited
Loading

It looks like this is already a seperate check.
For example, on #391, the test job == unit tests.
image

@dave-tucker
Copy link
Contributor

I've also verified that the exit code does indeed propagate correctly, although there is no feedback as to which test failed without reading the Junit report. I'll open an (optional) PR to address that but based on the description of the issue I think this can be closed.

dave-tucker added a commit to dave-tucker/eve that referenced this issue Nov 16, 2019
@dave-tucker
Use gotestsum To Run Unit Tests
927e699 
This commit uses the gotestsum tool to run unit tests.
gotestsum provides human-readable output from go test while also
outputting a Junit XML file.

Relates-To: lf-edge#121

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker dave-tucker mentioned this issue Nov 16, 2019
Merged
rvs pushed a commit that referenced this issue Nov 16, 2019
@dave-tucker @rvs
Use gotestsum To Run Unit Tests
32996d6 
This commit uses the gotestsum tool to run unit tests.
gotestsum provides human-readable output from go test while also
outputting a Junit XML file.

Relates-To: #121

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@milan-zededa
Copy link
Contributor

Done by @dave-tucker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rvs @dave-tucker @milan-zededa