Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Create .go/bin directory #391

Merged
merged 3 commits into from
Nov 17, 2019
Merged

Makefile: Create .go/bin directory #391

merged 3 commits into from
Nov 17, 2019

Conversation

dave-tucker
Copy link
Contributor

When checking out the project and running make test it fails as Docker
attempts to mount the .go/bin directory which doesn't exist. This
commit ensures that the directory exists and avoids the error.

Signed-off-by: Dave Tucker dave@dtucker.co.uk

When checking out the project and running `make test` it fails as Docker
attempts to mount the `.go/bin` directory which doesn't exist. This
commit ensures that the directory exists and avoids the error.

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@rvs
Copy link
Contributor

rvs commented Nov 16, 2019

That's a good catch @dave-tucker but I have to wonder why dave we not seen it fail before. Our CircleCI runs builds in a completely pristine environment on Linux and we all run builds on Mac OS too.

Can you share what exact set of steps made it fail? Starting from checking out the repo, etc.

@dave-tucker
Copy link
Contributor Author

Yep. Note that I'm on Windows 10 and developing using Ubuntu on Windows Subsystem for Linux (WSL) so it's a bit of a quirky setup. I have a hunch that it's because of the way that filesharing works in Docker for Windows.

$ git clone git@github.com:lf-edge/eve
$ cd eve
$ make test
Creating go builder image for user dave
eve-build-dave docker container is ready to use
mkdir -p /c/Users/dave/go/src/github.com/lf-edge/eve/dist/amd64
Running tests on github.com/lf-edge/eve/pkg/pillar
docker: Error response from daemon: Mount denied:
The source path "C:/Users/dave/go/src/github.com/lf-edge/eve/.go/bin"
doesn't exist and is not known to Docker.
See 'docker run --help'.
Makefile:145: recipe for target 'test' failed
make: *** [test] Error 125

Copy link
Contributor

@rvs rvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great -- you're the first one to have that setup with EVE! That's super helpful. Merging your change now.

Btw, do you also have qemu in your setup @dave-tucker ?

@rvs rvs merged commit 0ce1442 into lf-edge:master Nov 17, 2019
@dave-tucker
Copy link
Contributor Author

Btw, do you also have qemu in your setup @dave-tucker ?

Not just yet, but I plan to play around with getting it to work soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants