io/ioutil is deprecated #3021
Merged
io/ioutil is deprecated #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. Since we are bombarded with Yetus complains about ioutil in all our PRs, it is worth getting rid of it. Signed-off-by: Milan Lenco <milan@zededa.com>
|
@milan-zededa , there are only 5 Yetus errors. Wouldn't be worth to fix them and make 100% pass on this PR? |
eriknordmark
approved these changes
Feb 4, 2023
|
@rene @eriknordmark The problem is that the remaining "issues" do not make much sense or are even wrong wrt. our intentions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Go 1.16, the same functionality is now provided by package
ioor packageos, and those implementations should be preferred in new code.Since we are bombarded with Yetus complains about
ioutilin all our PRs, it is worth getting rid of it.Signed-off-by: Milan Lenco milan@zededa.com