Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio and plotter libraries and demonstrators #110

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Audio and plotter libraries and demonstrators #110

merged 4 commits into from
Jul 12, 2024

Conversation

edwardalee
Copy link
Contributor

This PR starts the development of libraries of reactors for audio and plotting. There are many more reactors that could and should be added here for this to be generally useful, including reactors that support plotting of multiple signals, more plotting styles, and other capabilities of matplotlib. For the audio, playing back audio from a file or from generated data would also be useful. In the meantime, this could serve as a model for what libraries should look like.

@edwardalee edwardalee added the enhancement New feature or request label May 30, 2024
@edwardalee
Copy link
Contributor Author

@lhstrh: any objections to merging this?

@edwardalee
Copy link
Contributor Author

I'm going ahead and merging this with only a self review. I do not believe this is controversial.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't get to this earlier, but this look good to merge!

@edwardalee edwardalee merged commit 8e8a783 into main Jul 12, 2024
5 checks passed
@edwardalee edwardalee deleted the audio branch July 12, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants