-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEGA65: ROWMASK function of RRB is not implemented #363
Comments
Can I take this one @lgblgblgb ? |
@hernandp Who am I to push you back? ;) Seriously now: of course. Thank you!! |
I believe this is the one in MEGA65-core. Just commenting some issues now to have some kind of link to the MEGA65-core material. Test program: https://github.com/MEGA65/mega65-tools/blob/master/src/tests/test_340.c PR on vic4test to test this feature: smnjameson/vic4tests#3 |
I consider this finished, at least no other feedback yet, and all mentioned cases/tests seem to be OK with the patch. |
RRB rowmask was implemented in #363 by me. However it seems, there is one important fact I missed: to clear RRB when it's not asked in case of a "GotoX token". Reported/suggested by RetroCogs.
Describe the bug
The ROWMASK function described in the "Bit Fields when GOTOX bit is set" section of "Displaying more than 256 unique characters via ”Super-Extended Attribute Mode”" does not appear to be implemented
Used version of the project
WINDOWS: console is open
INFO: DMA chip current revision: 1 (F018 rev-B, new)
ROM version detected: 920377 Closed-ROMs (installed,external)
ROM SHA1: 573e8be11f5641d4a8293a8aa0c17b3b3c5d16f0 (intact)
Last RESET type: XEMU-STARTUP
Hyppo version: master,20220117.14,f7554a8 (built-in)
HDOS virtualization: OFF, root = C:\Users\mgkai\AppData\Roaming\xemu-lgb\mega65\hdos
Disk8 = C:\Users\mgkai\AppData\Roaming\xemu-lgb\mega65\hdos\mega65.d81
Disk9 =
C64 'CPU' I/O port (low 3 bits): DDR=7 OUT=7
Current PC: $E1B3 (linear: $003E1B3)
Current VIC and I/O mode: VIC4 PAL, hot registers are enabled
Xemu host CPU usage so far: avg=185.58%, min=44%, max=18736% (860 counts), uptime=00:30
Xemu's host OS: Windows WINDOWS10-SCHOO 6.2 x86_64
To Reproduce
Expected behavior
At any given moment only one raster line of the rewritten character should be visible and should change as "N" or "M" are pressed since pressing "N" and "M" are changing the value in byte 1 of color ram on a character a character for which "GOTOX" is set. You can further prove that "GOTOX" is set for the character by pressing "S" and "D" to observe it moving left and right by a single pixel.
Screenshots
Computer/Device (please complete the following information):
Additional context
D81 Disk image with files mentioned in steps to reproduce
ELEVEN.zip
The text was updated successfully, but these errors were encountered: