Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bwape.c to allow equal reads in pair to be mapped as mapped in proper pair #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schultzdre
Copy link

Pre-processing tools like AfterQC and fastp can perform adapter clipping leaving both reads in a pair identical. This leads them to be mapped at the same location by aln, leading to (v).x == (u).x in the code below. The proposed change allows sampe to flag these as mapped in the proper pair.

Using some test data, this is a distribution of fragment lengths, pre-processed using fastp, mapped with aln and paired with sampe using the original code. Blue indicates mapped in proper pair (0x2 True) and red indicated otherwise (0x2 False).

test3

This is the same distribution with the proposed change:

test4

Thanks,
Andre

Allow two identical short reads to be flagged as mapped in proper pair.
@schultzdre schultzdre changed the title Update bwape.c Update bwape.c to allow equal reads in pair to be mapped as mapped in proper pair Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant