Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note on ends-free BiWFA #1

Closed
smarco opened this issue Apr 19, 2022 · 2 comments
Closed

Note on ends-free BiWFA #1

smarco opened this issue Apr 19, 2022 · 2 comments

Comments

@smarco
Copy link

smarco commented Apr 19, 2022

Hi,

I would like to highlight that the BiWFA can be applied to any ends-free alignment variation. If you think about it, you only need to change the initial conditions; that is, WF_0 of forward and reverse alignment need to allow starting at any diagonal (with offset zero).

Although, I'm not sure about how performant will this be compared to the regular WFA ends-free (i.e., for different sequence lengths, errors, and ends-free init length), from the algorithmic standpoint, I'm sure it is doable. In fact, I started to put that code into BiWFA, although I stopped for the sake of releasing a simpler code.

Cheers,

lh3 added a commit that referenced this issue Apr 19, 2022
@lh3
Copy link
Owner

lh3 commented Apr 19, 2022

Yes, you are right. I have removed the claim from README.

In practice, I guess it may be faster to use the standard WFA to find alignment ends and then reconstruct the base alignment with global BiWFA.

@smarco
Copy link
Author

smarco commented Apr 19, 2022

Yes, precisely. I have the same intuition.

@smarco smarco closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants