Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error return value #114

Closed
mjpworth opened this issue May 29, 2018 · 2 comments
Closed

error return value #114

mjpworth opened this issue May 29, 2018 · 2 comments

Comments

@mjpworth
Copy link

Hello,

Version: 1.2-r102-dirty seems to return 0 when it exits w/ error and when it executes successfully. i ran it with a arg file name that does not exist and while an error message is output:
[E::stk_seq] failed to open the input file/stream.
the return value captured by system() (in perl) or subprocess.call() (in python) is 0. a non-zero return value on error would be most convenient for error detection in scripting.

thanks for this useful tool.

@tseemann
Copy link

tseemann commented Jun 16, 2018

@mjpworth i agree, it is important to get the correct return codes (0=success, non-0=failure)

which sub-command of seqtk did you use?

if i give a non-existent filename, it usually just hangs waiting for something ....
eg. seqtk fqchk not_exist.fq or seqtk seq not_exist.fa

@lh3 lh3 closed this as completed in ef7157c Jun 17, 2018
@mjpworth
Copy link
Author

Thanks for the fix.

i just downloaded and installed the corrected version and it works as requested.

thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants