Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
LDFLAGS
to the linking step.A couple of further suggestions/questions:
$(LDFLAGS) -L.
.An alternative could be to have
LDFLAGS+=.L
and then use$(LDFLAGS)
afterwards.LIBS+=-fsanitize=*
lines.Those got me a little confused; these should be compiler flags and having them in
CFLAGS
should suffice, shouldn't it?CPPFLAGS=-DHAVE_KALLOC
toCPPFLAGS+=-DHAVE_KALLOC
?This way
CPPFLAGS
from the environment can be reused but the user still has the possibility to override viamake CPPFLAGS=...
.CFLAGS=...
toCFLAGS?=...
?With that, custom
CFLAGS
don't have to be explicitly passed on asmake
arguments.