Avoid modifying solution vector in TaoOptimizationSolver callbacks. #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the error: Object is in wrong state Vec is locked read only, argument # 1 we currently get when running the libmesh examples using a PETSc built with --with-debugging=1. Refs libMesh#1889. See also: libMesh#1294, libMesh#630.
|
I verified using a local PETSc-debug build that the optimization solvers both run with the changes on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1889 (and previously in #630 and #1294) we cannot modify the solution vector by enforcing constraints in the PETSc callback functions but we can enforce the constraints on
current_local_solution, which is not locked read only.cc: @andfranklin