Update abaqus_io.C #2316
Closed
Update abaqus_io.C #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for reading ABAQUS .inp file with *Surface referring to element sets
Deleted trailing whitespaces
Fixed duplicate variable names and indentation
|
You may have already fixed this, but the complex numbers build failed because there was a warning and we have -Werror turned on for that build. |
|
@jwpeterson thanks a lot for looking into this for me! Just got this fixed :) |
jwpeterson
requested changes
Oct 30, 2019
Switched to using libmesh_map_find
Stored elem_id_or_set as John suggested
Fixed a typo
|
FYI @yw5aj I sent you an invite to join a libMesh group whose PRs are tested automatically. I started all the tests manually just now but I'm confused, yesterday your PR seemed to be testing fine on its own... |
|
No, I was activating them.
…On Thu, Oct 31, 2019 at 8:15 AM John W. Peterson ***@***.***> wrote:
FYI @yw5aj <https://github.com/yw5aj> I sent you an invite to join a
libMesh group whose PRs are tested automatically. I just started all the
tests manually just now but I'm confused, yesterday your PR seemed to be
testing just fine on its own...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2316?email_source=notifications&email_token=AAXFOIE6ZFNO53CJA67KCUDQRLSB5A5CNFSM4JHA3ZFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECX5ZDY#issuecomment-548396175>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXFOIEMBYLQSS5TA5BLLBDQRLSB5ANCNFSM4JHA3ZFA>
.
|
jwpeterson
added a commit
to jwpeterson/libmesh
that referenced
this pull request
Oct 31, 2019
…lement sets Co-authored-by: Yuxiang Wang <shwang@aligntech.com> Refs libMesh#2316.
|
Replaced by #2317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for reading ABAQUS .inp file with *Surface referring to element sets