Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Automake's pkginclude feature #28

Merged
merged 1 commit into from
Oct 28, 2013
Merged

Use Automake's pkginclude feature #28

merged 1 commit into from
Oct 28, 2013

Conversation

RhysU
Copy link
Contributor

@RhysU RhysU commented Oct 28, 2013

Automake has a magic prefix for the common $(includedir)/$(PACKAGE)
idiom that was in use previously.

Automake has a magic prefix for the common $(includedir)/$(PACKAGE)
idiom that was in use previously.
@pbauman
Copy link
Member

pbauman commented Oct 28, 2013

Any idea what version of Automake this went in? I believe you can set a minimum version in AM_INIT so want to make sure we don't need to update.

@RhysU
Copy link
Contributor Author

RhysU commented Oct 28, 2013

http://git.savannah.gnu.org/cgit/automake.git/tree/old/ChangeLog.96 says that feature landed in 1996.

@RhysU
Copy link
Contributor Author

RhysU commented Oct 28, 2013

Or, rather, the tail end of 1995. Either way.

@roystgnr
Copy link
Contributor

I was about to criticize Rhys for giving a revision number rather than a version number, but wait... that's a year number. So automake version is not a worry.

Any advantages to the change other than not having to set includedir?

@RhysU
Copy link
Contributor Author

RhysU commented Oct 28, 2013

None. Just brings it into alignment with common Automake idioms.

@roystgnr
Copy link
Contributor

(either way I'd say this is good to merge, BTW; I just wanted to know if there'd be much payoff for digging through our other similarly organized autotools projects and making the same change)

@pbauman
Copy link
Member

pbauman commented Oct 28, 2013

Merging.

pbauman added a commit that referenced this pull request Oct 28, 2013
Use Automake's pkginclude feature
@pbauman pbauman merged commit 4be2d3a into libantioch:master Oct 28, 2013
@RhysU RhysU deleted the pkginclude branch October 28, 2013 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants