Use optimized iostream.

include/bitcoin/network/error.hpp

@@ -50,7 +50,7 @@ typedef boost::asio::error::basic_errors asio_system_error_t;
 /// Asio failures are normalized to the error codes below.
 /// Stop by explicit call is mapped to channel_stopped or service_stopped
 /// depending on the context. Asio errors returned on cancel calls are ignored.
-enum error_t
+enum error_t : uint8_t
 {
     success,
     unknown,

src/messages/address.cpp

@@ -43,7 +43,8 @@ constexpr auto with_timestamp = true;
 typename address::cptr address::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -68,7 +69,8 @@ address address::deserialize(uint32_t version, system::reader& source) NOEXCEPT
 bool address::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/alert.cpp

@@ -40,7 +40,8 @@ const uint32_t alert::version_maximum = level::maximum_protocol;
 typename alert::cptr alert::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -66,7 +67,8 @@ alert alert::deserialize(uint32_t version, reader& source) NOEXCEPT
 bool alert::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/block.cpp

@@ -40,7 +40,8 @@ const uint32_t block::version_maximum = level::maximum_protocol;
 typename block::cptr block::deserialize(uint32_t version,
     const system::data_chunk& data, bool witness) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader, witness));
     if (!reader)
         return nullptr;
@@ -96,7 +97,8 @@ block block::deserialize(uint32_t version, reader& source,
 bool block::serialize(uint32_t version,
     const system::data_slab& data, bool witness) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer, witness);
     return writer;
 }

src/messages/bloom_filter_add.cpp

@@ -39,7 +39,8 @@ const uint32_t bloom_filter_add::version_maximum = level::maximum_protocol;
 typename bloom_filter_add::cptr bloom_filter_add::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -57,7 +58,8 @@ bloom_filter_add bloom_filter_add::deserialize(uint32_t version,
 bool bloom_filter_add::serialize(uint32_t version,
     const system::data_slab& data_) const NOEXCEPT
 {
-    write::bytes::copy writer(data_);
+    system::ostream sink{ data_ };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/bloom_filter_clear.cpp

@@ -44,7 +44,8 @@ size_t bloom_filter_clear::size(uint32_t) NOEXCEPT
 typename bloom_filter_clear::cptr bloom_filter_clear::deserialize(
     uint32_t version, const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -62,7 +63,8 @@ bloom_filter_clear bloom_filter_clear::deserialize(uint32_t version,
 bool bloom_filter_clear::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/bloom_filter_load.cpp

@@ -39,7 +39,8 @@ const uint32_t bloom_filter_load::version_maximum = level::maximum_protocol;
 typename bloom_filter_load::cptr bloom_filter_load::deserialize(
     uint32_t version, const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -73,7 +74,8 @@ bloom_filter_load bloom_filter_load::deserialize(uint32_t version,
 bool bloom_filter_load::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/client_filter.cpp

@@ -41,7 +41,8 @@ const uint32_t client_filter::version_maximum = level::maximum_protocol;
 typename client_filter::cptr client_filter::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -64,7 +65,8 @@ client_filter client_filter::deserialize(uint32_t version,
 bool client_filter::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/client_filter_checkpoint.cpp

@@ -41,7 +41,8 @@ const uint32_t client_filter_checkpoint::version_maximum = level::maximum_protoc
 typename client_filter_checkpoint::cptr client_filter_checkpoint::deserialize(
     uint32_t version, const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -76,7 +77,8 @@ client_filter_checkpoint client_filter_checkpoint::deserialize(
 bool client_filter_checkpoint::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/client_filter_headers.cpp

@@ -41,7 +41,8 @@ const uint32_t client_filter_headers::version_maximum = level::maximum_protocol;
 typename client_filter_headers::cptr client_filter_headers::deserialize(
     uint32_t version, const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -77,7 +78,8 @@ client_filter_headers client_filter_headers::deserialize(uint32_t version,
 bool client_filter_headers::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/compact_block.cpp

@@ -40,7 +40,8 @@ const uint32_t compact_block::version_maximum = level::maximum_protocol;
 typename compact_block::cptr compact_block::deserialize(uint32_t version,
     const system::data_chunk& data, bool witness) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader, witness));
     return reader ? message : nullptr;
 }
@@ -89,7 +90,8 @@ compact_block compact_block::deserialize(uint32_t version, reader& source,
 bool compact_block::serialize(uint32_t version,
     const system::data_slab& data, bool witness) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer, witness);
     return writer;
 }

src/messages/compact_transactions.cpp

@@ -39,7 +39,8 @@ const uint32_t compact_transactions::version_maximum = level::maximum_protocol;
 typename compact_transactions::cptr compact_transactions::deserialize(
     uint32_t version, const system::data_chunk& data, bool witness) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader, witness));
     return reader ? message : nullptr;
 }
@@ -74,7 +75,8 @@ compact_transactions compact_transactions::deserialize(uint32_t version,
 bool compact_transactions::serialize(uint32_t version,
     const system::data_slab& data, bool witness) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer, witness);
     return writer;
 }

src/messages/fee_filter.cpp

@@ -44,7 +44,8 @@ size_t fee_filter::size(uint32_t) NOEXCEPT
 typename fee_filter::cptr fee_filter::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -61,7 +62,8 @@ fee_filter fee_filter::deserialize(uint32_t version, reader& source) NOEXCEPT
 bool fee_filter::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/get_address.cpp

@@ -44,7 +44,8 @@ size_t get_address::size(uint32_t) NOEXCEPT
 typename get_address::cptr get_address::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -61,7 +62,8 @@ get_address get_address::deserialize(uint32_t version, reader& source) NOEXCEPT
 bool get_address::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/get_blocks.cpp

@@ -75,7 +75,8 @@ get_blocks::indexes get_blocks::heights(size_t top) NOEXCEPT
 typename get_blocks::cptr get_blocks::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -114,7 +115,8 @@ get_blocks get_blocks::deserialize(uint32_t version, reader& source) NOEXCEPT
 bool get_blocks::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/get_client_filter_checkpoint.cpp

@@ -49,7 +49,8 @@ typename get_client_filter_checkpoint::cptr
 get_client_filter_checkpoint::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -71,7 +72,8 @@ get_client_filter_checkpoint get_client_filter_checkpoint::deserialize(
 bool get_client_filter_checkpoint::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/get_client_filter_headers.cpp

@@ -50,7 +50,8 @@ typename get_client_filter_headers::cptr
 get_client_filter_headers::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -73,7 +74,8 @@ get_client_filter_headers get_client_filter_headers::deserialize(
 bool get_client_filter_headers::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/get_client_filters.cpp

@@ -49,7 +49,8 @@ size_t get_client_filters::size(uint32_t) NOEXCEPT
 typename get_client_filters::cptr get_client_filters::deserialize(
     uint32_t version, const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -72,7 +73,8 @@ get_client_filters get_client_filters::deserialize(uint32_t version,
 bool get_client_filters::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/get_compact_transactions.cpp

@@ -39,7 +39,8 @@ const uint32_t get_compact_transactions::version_maximum = level::maximum_protoc
 typename get_compact_transactions::cptr get_compact_transactions::deserialize(
     uint32_t version, const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -73,7 +74,8 @@ get_compact_transactions get_compact_transactions::deserialize(uint32_t version,
 bool get_compact_transactions::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }

src/messages/get_data.cpp

@@ -42,7 +42,8 @@ const uint32_t get_data::version_maximum = level::maximum_protocol;
 typename get_data::cptr get_data::deserialize(uint32_t version,
     const system::data_chunk& data) NOEXCEPT
 {
-    read::bytes::copy reader(data);
+    system::istream source{ data };
+    system::byte_reader reader{ source };
     const auto message = to_shared(deserialize(version, reader));
     return reader ? message : nullptr;
 }
@@ -66,7 +67,8 @@ get_data get_data::deserialize(uint32_t version, reader& source) NOEXCEPT
 bool get_data::serialize(uint32_t version,
     const system::data_slab& data) const NOEXCEPT
 {
-    write::bytes::copy writer(data);
+    system::ostream sink{ data };
+    system::byte_writer writer{ sink };
     serialize(version, writer);
     return writer;
 }