Splits Engine implementation into multiple classes #178 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engine is no longer a God-like class. The interface remains the same but it now delegates its logic onto: - EntityManager - SystemManager - FamilyManager - ComponentOperationHandler
dsaltares
force-pushed
the
engine-refactor
branch
from
bb11832
to
261342f
Compare
|
Okay, merging now, we can make changes to this later. I think it's good because the smaller classes know nothing about the Engine, everything has unit tests (and the Engine's tests now become more of integration tests). |
dsaltares
added a commit
that referenced
this pull request
Dec 12, 2015
Splits Engine implementation into multiple classes #178
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine is no longer a God-like class. The interface remains the same but it now delegates its logic onto:
EntityManagerSystemManagerFamilyManagerComponentOperationHandlerThe internal classes are package-protected because there's absolutely 0 need to expose them to the user. I could have made them internal private classes of the Engine, but it would have defeated the purpose.
I've added unit tests for each one of them and maintained
EngineTestsas integration tests.