Added minimizing JRE from config. Broke compat! #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimizejre option in config files must be a string, not a raw true/false (use "true" or "false" for the same stuff, or "soft" or a "path/to/a/file")
badlogic
added a commit
that referenced
this pull request
May 17, 2014
Added minimizing JRE from config. Broke compat!
karlsabo
added a commit
that referenced
this pull request
Sep 9, 2020
Altered to work with Java 8 and 9+ JREs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimizejre option in config files must be a string, not a raw
true/false (use "true" or "false" for the same stuff, or "soft" or a
"path/to/a/file"). To be perfectly honest I haven't tried the file
handling yet, but it can do soft and hard removal of parts of
rt.jar, of which soft removal fills some requirements, namely
issue 6. I am fairly certain there's a better way to do this, but
I just want to have this out there as a starting point.