-
Notifications
You must be signed in to change notification settings - Fork 324
[next] Add stash support #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we have an update on this? |
Is there anything that can be done to have this PR reviewed and merged? |
Still nothing? |
if ecode < 0 { | ||
return StashApplyOptions{}, MakeGitError(ecode) | ||
} | ||
defer freeStashApplyOptions(&optsC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you're using optsC
to copy the defaults into the Go struct. In that case, you haven't allocated anything, so there's nothing to free.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I must've copied this from cherrypick.go, so it should be fixed there as well.
Thanks for the review. I made the changes, pushed them and commented on some. |
No description provided.