[next] Add stash support #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have an update on this? |
|
Is there anything that can be done to have this PR reviewed and merged? |
|
Still nothing? |
stash.go
Outdated
| if ecode < 0 { | ||
| return StashApplyOptions{}, MakeGitError(ecode) | ||
| } | ||
| defer freeStashApplyOptions(&optsC) |
There was a problem hiding this comment.
It looks like you're using optsC to copy the defaults into the Go struct. In that case, you haven't allocated anything, so there's nothing to free.
There was a problem hiding this comment.
Yeah, I must've copied this from cherrypick.go, so it should be fixed there as well.
clns
added a commit
to clns/git2go
that referenced
this pull request
Feb 20, 2016
|
Thanks for the review. I made the changes, pushed them and commented on some. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.