Skip to content

Conversation

clns
Copy link
Contributor

@clns clns commented Sep 21, 2015

No description provided.

@clns
Copy link
Contributor Author

clns commented Oct 20, 2015

Can we have an update on this?

@clns
Copy link
Contributor Author

clns commented Nov 16, 2015

Is there anything that can be done to have this PR reviewed and merged?

@clns
Copy link
Contributor Author

clns commented Feb 17, 2016

Still nothing?

if ecode < 0 {
return StashApplyOptions{}, MakeGitError(ecode)
}
defer freeStashApplyOptions(&optsC)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're using optsC to copy the defaults into the Go struct. In that case, you haven't allocated anything, so there's nothing to free.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I must've copied this from cherrypick.go, so it should be fixed there as well.

clns added a commit to clns/git2go that referenced this pull request Feb 20, 2016
@clns
Copy link
Contributor Author

clns commented Mar 16, 2016

Thanks for the review. I made the changes, pushed them and commented on some.

carlosmn added a commit that referenced this pull request Mar 17, 2016
@carlosmn carlosmn merged commit 836b6c5 into libgit2:next Mar 17, 2016
@clns clns deleted the stash-support branch April 26, 2016 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants