[WIP] Use Go's TLS stream instead of whatever the library ships with #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having to guess about how to make the TLS stream safe on the given platform, we can use a managed one we implement ourselves and tell libgit2 to use that.
|
I just landed #810, which was heavily based upon this change, with proxy support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us have a more consistent set of features across platforms and avoids having to worry about OpenSSL's locking support as much (since crypto itself doesn't seem to need it).
There is no support for proxies in this state. libgit2 itself only supports proxies either on Windows (at a HTTP level which wouldn't use this code anyway) and by piggy-backing off of curl, which this doesn't do either.
I'm not familiar with what proxy support exists in the Go ecosystem, but I assume there must be something that'll let us do HTTP tunneling.