Skip to content

Add DiffIgnoreWitespaceEol and deprecate DiffIgnoreWitespaceEol #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 4, 2021

Conversation

zegl
Copy link
Contributor

@zegl zegl commented Aug 24, 2021

DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes #773

Copy link
Contributor

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zegl, good catch.

DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes libgit2#773
@zegl zegl force-pushed the whitespace-typo branch from 616fe35 to d3df19f Compare August 25, 2021 10:03
Copy link
Contributor

@lhchavez lhchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at the CI failures :/

@lhchavez
Copy link
Contributor

lhchavez commented Sep 3, 2021

CI should be fixed by #776 !

@lhchavez lhchavez merged commit d452476 into libgit2:main Sep 4, 2021
github-actions bot pushed a commit that referenced this pull request Sep 4, 2021
DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes #773

(cherry picked from commit d452476)
lhchavez pushed a commit that referenced this pull request Sep 4, 2021
#793)

DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes #773

(cherry picked from commit d452476)

Co-authored-by: Gustav Westling <gustav@westling.dev>
lhchavez pushed a commit that referenced this pull request Sep 4, 2021
DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes #773

(cherry picked from commit d452476)
lhchavez pushed a commit that referenced this pull request Sep 4, 2021
DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes #773

(cherry picked from commit d452476)
lhchavez added a commit that referenced this pull request Sep 4, 2021
#795)

DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes #773

(cherry picked from commit d452476)

Co-authored-by: Gustav Westling <gustav@westling.dev>
lhchavez added a commit that referenced this pull request Sep 4, 2021
#794)

DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes #773

(cherry picked from commit d452476)

Co-authored-by: Gustav Westling <gustav@westling.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in "DiffIgnoreWitespaceEol"
3 participants