cmake: enable -Wformat and -Wformat-security #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently have any warnings in this regard, but it's good practice to have them on in case we introduce something.
carlosmn
force-pushed
the
cmn/format-security
branch
from
bef5e49
to
f2c1153
Compare
|
/rebuild |
|
Okay, @ethomson, I started to rebuild this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently have any warnings in this regard, but it's good practice to
have them on in case we introduce something.
Ideally we would also have
-Wformat-nonliteralbut we actually use it a lot and at least GCC cannot differentiate between static strings and stuff we've accepted from users, unfortunately.