New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature default encoding? #581

Closed

bors-ltd opened this issue Nov 15, 2015 · 0 comments

Contributor

bors-ltd commented Nov 15, 2015

Hi,

It's not documented but it seems the default encoding for the signature name is ASCII: https://github.com/libgit2/pygit2/blob/master/src/signature.c#L41

Is there a particular reason why it's not UTF-8, like about everything else in git/libgit2?

When I pass a unicode/text object, I wouldn't expect to provide the encoding as well (there is an accent in my name).

Especially when it seems to be the default for internally built signatures: https://github.com/libgit2/pygit2/blob/master/src/signature.c#L114

jdavid closed this as completed in

7a8474c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment