Add Stash type, Repository.listall_stashes #1117

jorio · 2022-01-26T00:43:00Z

Issue #885

jdavid · 2022-01-26T10:24:07Z

src/stash.c

+    if (!self->oid)
+        Py_RETURN_NONE;


I don't think this can be NULL. If it's then there was an error when it was set, and it should be handled there.
So please remove testing whether oid is NULL through the code. And check whether git_oid_to_python returns NULL in foreach_stash_cb, if it does then there has been an error.

jdavid · 2022-01-26T10:27:57Z

src/stash.c

+    if (!self->message)
+        Py_RETURN_NONE;


I think the same applies here. I can imagine the message to be an empty string but not NULL.
So please remove testing whether message is NULL through the code.

jdavid · 2022-01-26T10:32:26Z

src/repository.c

+    py_stash->oid = git_oid_to_python(stash_id);
+    py_stash->message = (message != NULL) ? strdup(message) : NULL;


As said in the other comments, I think message and stash_id cannot be NULL. So please add an assert statement for each one. Then check whether git_oid_to_python or strdup return NULL, that would mean a memory error.

jdavid · 2022-01-26T10:37:27Z

src/stash.c

+PyTypeObject StashType;
+
+
+PyDoc_STRVAR(Stash_oid__doc__, "Stashed state.");


Please change to the more informative The commit id of the stashed state.

jdavid · 2022-01-26T10:43:00Z

src/stash.c

+PyDoc_STRVAR(Stash_oid__doc__, "Stashed state.");
+
+PyObject *
+Stash_oid__get__(Stash *self)


Please rename to commit_id, I think that's more clear.

Issue libgit2#885

jorio · 2022-01-26T11:37:36Z

Thank you for your review! I have addressed your feedback in 1205eb7 and added some documentation for the new features as well.

jdavid · 2022-01-26T15:07:56Z

Merged, thanks for your contribution!

1.10.1 (2022-08-28) ------------------------- - Fix segfault in ``Signature`` repr `#1155 <https://github.com/libgit2/pygit2/pull/1155>`_ - Linux and macOS wheels for Python 3.11 `#1154 <https://github.com/libgit2/pygit2/pull/1154>`_ 1.10.0 (2022-07-24) ------------------------- - Upgrade to libgit2 1.5 - Add support for ``GIT_OPT_GET_OWNER_VALIDATION`` and ``GIT_OPT_SET_OWNER_VALIDATION`` `#1150 <https://github.com/libgit2/pygit2/pull/1150>`_ - New ``untracked_files`` and ``ignored`` optional arguments for ``Repository.status(...)`` `#1151 <https://github.com/libgit2/pygit2/pull/1151>`_ 1.9.2 (2022-05-24) ------------------------- - New ``Repository.create_commit_string(...)`` and ``Repository.create_commit_with_signature(...)`` `#1142 <https://github.com/libgit2/pygit2/pull/1142>`_ - Linux and macOS wheels updated to libgit2 v1.4.3 - Remove redundant line `#1139 <https://github.com/libgit2/pygit2/pull/1139>`_ 1.9.1 (2022-03-22) ------------------------- - Type hints: added to C code and Branches/References `#1121 <https://github.com/libgit2/pygit2/pull/1121>`_ `#1132 <https://github.com/libgit2/pygit2/pull/1132>`_ - New ``Signature`` supports ``str()`` and ``repr()`` `#1135 <https://github.com/libgit2/pygit2/pull/1135>`_ - Fix ODB backend's read in big endian architectures `#1130 <https://github.com/libgit2/pygit2/pull/1130>`_ - Fix install with poetry `#1129 <https://github.com/libgit2/pygit2/pull/1129>`_ `#1128 <https://github.com/libgit2/pygit2/issues/1128>`_ - Wheels: update to libgit2 v1.4.2 - Tests: fix testing ``parse_diff`` `#1131 <https://github.com/libgit2/pygit2/pull/1131>`_ - CI: various fixes after migration to libgit2 v1.4 1.9.0 (2022-02-22) ------------------------- - Upgrade to libgit2 v1.4 - Documentation, new recipes for committing and cloning `#1125 <https://github.com/libgit2/pygit2/pull/1125>`_ 1.8.0 (2022-02-04) ------------------------- - Rename ``RemoteCallbacks.progress(...)`` callback to ``.sideband_progress(...)`` `#1120 <https://github.com/libgit2/pygit2/pull/1120>`_ - New ``Repository.merge_base_many(...)`` and ``Repository.merge_base_octopus(...)`` `#1112 <https://github.com/libgit2/pygit2/pull/1112>`_ - New ``Repository.listall_stashes()`` `#1117 <https://github.com/libgit2/pygit2/pull/1117>`_ - Code cleanup `#1118 <https://github.com/libgit2/pygit2/pull/1118>`_ Backward incompatible changes: - The ``RemoteCallbacks.progress(...)`` callback has been renamed to ``RemoteCallbacks.sideband_progress(...)``. This matches the documentation, but may break existing code that still uses the old name. 1.7.2 (2021-12-06) ------------------------- - Universal wheels for macOS `#1109 <https://github.com/libgit2/pygit2/pull/1109>`_ 1.7.1 (2021-11-19) ------------------------- - New ``Repository.amend_commit(...)`` `#1098 <https://github.com/libgit2/pygit2/pull/1098>`_ - New ``Commit.message_trailers`` `#1101 <https://github.com/libgit2/pygit2/pull/1101>`_ - Windows wheels for Python 3.10 `#1103 <https://github.com/libgit2/pygit2/pull/1103>`_ - Changed: now ``DiffDelta.is_binary`` returns ``None`` if the file data has not yet been loaded, cf. `#962 <https://github.com/libgit2/pygit2/issues/962>`_ - Document ``Repository.get_attr(...)`` and update theme `#1017 <https://github.com/libgit2/pygit2/issues/1017>`_ `#1105 <https://github.com/libgit2/pygit2/pull/1105>`_ 1.7.0 (2021-10-08) ------------------------- - Upgrade to libgit2 1.3.0 `#1089 <https://github.com/libgit2/pygit2/pull/1089>`_ - Linux wheels now bundled with libssh2 1.10.0 (instead of 1.9.0) - macOS wheels now include libssh2 - Add support for Python 3.10 `#1092 <https://github.com/libgit2/pygit2/pull/1092>`_ `#1093 <https://github.com/libgit2/pygit2/pull/1093>`_ - Drop support for Python 3.6 - New `pygit2.GIT_CHECKOUT_SKIP_LOCKED_DIRECTORIES` `#1087 <https://github.com/libgit2/pygit2/pull/1087>`_ - New optional argument ``location`` in ``Repository.applies(..)`` and ``Repository.apply(..)`` `#1091 <https://github.com/libgit2/pygit2/pull/1091>`_ - Fix: Now the `flags` argument in `Repository.blame()` is passed through `#1083 <https://github.com/libgit2/pygit2/pull/1083>`_ - CI: Stop using Travis, move to GitHub actions Caveats: - Windows wheels for Python 3.10 not yet available.

jorio changed the title ~~Add Stash, Repository.listall_stashes~~ Add Stash type, Repository.listall_stashes Jan 26, 2022

jorio force-pushed the listall_stashes branch from 18bb562 to 0561be8 Compare January 26, 2022 10:14

jdavid requested changes Jan 26, 2022

View reviewed changes

Add Stash, Repository.listall_stashes

1205eb7

Issue libgit2#885

jorio force-pushed the listall_stashes branch from 0561be8 to 1205eb7 Compare January 26, 2022 11:18

Document Repository.listall_stashes

cad724e

jdavid merged commit cad724e into libgit2:master Jan 26, 2022

jdavid mentioned this pull request Jan 26, 2022

Missing ability to "stash list" #885

Closed

jorio deleted the listall_stashes branch March 6, 2022 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Stash type, Repository.listall_stashes #1117

Add Stash type, Repository.listall_stashes #1117

jorio commented Jan 26, 2022

jdavid Jan 26, 2022

jdavid Jan 26, 2022

jdavid Jan 26, 2022

jdavid Jan 26, 2022

jdavid Jan 26, 2022

jorio commented Jan 26, 2022

jdavid commented Jan 26, 2022

		py_stash->oid = git_oid_to_python(stash_id);
		py_stash->message = (message != NULL) ? strdup(message) : NULL;

		PyTypeObject StashType;


		PyDoc_STRVAR(Stash_oid__doc__, "Stashed state.");

Add Stash type, Repository.listall_stashes #1117

Add Stash type, Repository.listall_stashes #1117

Conversation

jorio commented Jan 26, 2022

jdavid Jan 26, 2022

Choose a reason for hiding this comment

jdavid Jan 26, 2022

Choose a reason for hiding this comment

jdavid Jan 26, 2022

Choose a reason for hiding this comment

jdavid Jan 26, 2022

Choose a reason for hiding this comment

jdavid Jan 26, 2022

Choose a reason for hiding this comment

jorio commented Jan 26, 2022

jdavid commented Jan 26, 2022