New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.3 compat #351

Merged
merged 2 commits into from Mar 24, 2014

Conversation

Projects
None yet
2 participants
@carlosmn
Member

carlosmn commented Mar 23, 2014

The behaviour of __slots__ has changed a bit in 3.3, so let's make sure we don't use it for properties we add later. Take this opportunity to insert some documentation.

carlosmn added some commits Mar 23, 2014

settings: python 3.3 compat
Python 3.3 doesn't like us overriding properties in __slots__, so set it
to an empty list.
Settings: add documentation
The search_path attribute is now inside __init__() so it shows properly
in the generated documentation.

@jdavid jdavid merged commit 87c8aef into libgit2:master Mar 24, 2014

1 check passed

default The Travis CI build passed
Details

@carlosmn carlosmn deleted the carlosmn:settings-3.3 branch Mar 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment