improve credentials handling for ssh cloning #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobcarroll
force-pushed
the
credtype-username
branch
2 times, most recently
from
969661c to
7da6992
Compare
bobcarroll
force-pushed
the
credtype-username
branch
from
7da6992 to
9ab0f37
Compare
bobcarroll
added a commit
to bobcarroll/pygit2
that referenced
this pull request
Oct 26, 2017
bobcarroll
added a commit
to bobcarroll/pygit2
that referenced
this pull request
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements support for the
GIT_CREDTYPE_USERNAMEcredential. The ssh transport requests this when negotiating authentication methods with libssh2. It seems the only other way to clone over ssh is to include the username in the repository URL, which is undocumented and inconsistent with the behavior prior to the credential callback.