Give patch reference to underlying blob(s) #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #754 and also allows merging of #758 .
As described in #754, Patch objects do not have a reference to their underlying blobs. Thus, if the blob is freed before patch text is generated, the patch text becomes mangled. This is ultimately an issue in libgit2 and the issue is being tracked in libgit2/libgit2#4442
In the meantime, the problem can be solved at the pygit2 level. This PR adds blob references to the pygit2 Patch objects and increments their reference counters when a patch with blobs is generated.
When the fix is ultimately merged into libgit2, this behavior should probably be removed from pygit2. Until then, this is a good fix!