Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate generic utilities from Cyberpunk framework #183

Open
4 of 5 tasks
czyzby opened this issue Feb 5, 2019 · 2 comments
Open
4 of 5 tasks

Integrate generic utilities from Cyberpunk framework #183

czyzby opened this issue Feb 5, 2019 · 2 comments
Assignees
Labels
app Issues of the ktx-app module graphics Issues of the ktx-graphics module
Milestone

Comments

@czyzby
Copy link
Member

czyzby commented Feb 5, 2019

Cyberpunk is an opinionated Kotlin LibGDX framework that aims to be on a little higher abstraction level than KTX. Some of its utilities are generic enough to make it into KTX. In particular, we should look into:

  • Screenshot utilities.
  • Profiling.
  • Camera utilities.
  • Image and text helpers.
  • Refactoring and addressing feedback (see comments below).

See ImXico/Cyberpunk#14. @ImXico

@czyzby czyzby self-assigned this Feb 5, 2019
@czyzby czyzby added app Issues of the ktx-app module graphics Issues of the ktx-graphics module labels Feb 5, 2019
@czyzby czyzby added this to the backlog milestone Feb 5, 2019
@czyzby czyzby added the good first issue Simple tasks that do not require advanced knowledge of KTX or LibGDX label Jun 2, 2019
czyzby added a commit that referenced this issue Mar 26, 2020
czyzby added a commit that referenced this issue Mar 26, 2020
czyzby added a commit that referenced this issue Mar 26, 2020
czyzby added a commit that referenced this issue Mar 26, 2020
@czyzby czyzby removed the good first issue Simple tasks that do not require advanced knowledge of KTX or LibGDX label Mar 26, 2020
@czyzby czyzby modified the milestones: backlog, 1.9.10 Mar 26, 2020
@czyzby
Copy link
Member Author

czyzby commented Mar 26, 2020

@ImXico I finally got around to move some utilities from Cyberpunk to KTX. I credited you in the contributors file, I hope that's OK. Thanks again!

@czyzby czyzby closed this as completed Mar 26, 2020
This was referenced Mar 26, 2020
@czyzby
Copy link
Member Author

czyzby commented Mar 29, 2020

Some feedback to consider:

  • Camera: from what I can tell it would be nice to also support a version without Vector2 and simply pass targetX and targetY
  • Text helpers: I wanted to use that for my floating texts but there is only a "String" version and I have a stringbuilder. Maybe there would be an option to also use stringbuilder? Second, and more important to me, it creates a Vector2 object. Since my texts are floating (=moving) I would create a vector2 object per frame. I would either need to redesign my code for this function or there should be an option to pass in a Vector2 object which will then contain the result.

@czyzby czyzby reopened this Mar 29, 2020
@czyzby czyzby modified the milestones: 1.9.10, backlog Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues of the ktx-app module graphics Issues of the ktx-graphics module
Projects
None yet
Development

No branches or pull requests

1 participant