Skip to content

Conversation

ShigekiKarita
Copy link
Member

No description provided.

@ShigekiKarita
Copy link
Member Author

ShigekiKarita commented Nov 15, 2018

without this fix, cannot_create_f_contiguous_buffer is not found because it lacks of typeof(return). under

static if (kind == Contiguous)

dub test --build=unittest-cov                                                                                                                                 
Generating test runner configuration 'mir-algorithm-test-default' for 'default' (library).                                                                                                                      
Excluding package.d file from test due to https://issues.dlang.org/show_bug.cgi?id=11847                                                                                                                        
Excluding package.d file from test due to https://issues.dlang.org/show_bug.cgi?id=11847                                                                                                                        
Excluding package.d file from test due to https://issues.dlang.org/show_bug.cgi?id=11847                                                                                                                        
Excluding package.d file from test due to https://issues.dlang.org/show_bug.cgi?id=11847                                                                                                                        
Performing "unittest-cov" build using /home/skarita/dlang/dmd-2.083.0/linux/bin64/dmd for x86_64.                                                                                                               
mir-core 0.0.11: target for configuration "library" is up to date.                                                                                                                                              
mir-algorithm 0.6.13+commit.306.ga6fb479: building configuration "mir-algorithm-test-default"...                                                                                                                
Warning: multivariate cubic spline with derivatives was not tested!!!                                                                                                                                           
Warning: multivariate cubic spline with derivatives was not tested!!!                                                                                                                                           
source/mir/ndslice/connect/cpython.d(163,28): Error: undefined identifier cannot_create_f_contiguous_buffer                                                                                                     
source/mir/ndslice/connect/cpython.d(229,46): Error: template instance `mir.ndslice.connect.cpython.toPythonBuffer!(double, 2LU, cast(mir_slice_kind)2)` error instantiating                                    
source/mir/ndslice/connect/cpython.d(244,20):        instantiated from here: bar!cast(mir_slice_kind)2  

@codecov-io
Copy link

codecov-io commented Nov 15, 2018

Codecov Report

Merging #159 into master will decrease coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   92.65%   92.61%   -0.04%     
==========================================
  Files          34       34              
  Lines        7175     7180       +5     
==========================================
+ Hits         6648     6650       +2     
- Misses        527      530       +3
Impacted Files Coverage Δ
source/mir/ndslice/connect/cpython.d 5.63% <75%> (+2.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6fb479...ba7ad3d. Read the comment docs.

@9il
Copy link
Member

9il commented Nov 15, 2018

Thanks!

@9il 9il merged commit 41cfb8d into libmir:master Nov 16, 2018
@9il
Copy link
Member

9il commented Nov 16, 2018

v3.1.9

@ShigekiKarita ShigekiKarita deleted the fix-cpython branch November 16, 2018 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants