merge with mir-runtime #222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
- Coverage 92.19% 91.02% -1.17%
==========================================
Files 44 49 +5
Lines 8368 8938 +570
==========================================
+ Hits 7715 8136 +421
- Misses 653 802 +149
Continue to review full report at Codecov.
|
| @@ -20,9 +20,11 @@ buildType "unittest-release" { | |||
| versions "mir_test" | |||
| } | |||
|
|
|||
| dflags "-preview=dip1008" | |||
|
|
|||
There was a problem hiding this comment.
was this deliberate? It breaks anyone who can't use dip1008.
Also, dub doesn't propagate dflags to the whole build, only to packages that depend on the package that sets them, which means you end up building part of the build with dip1008 and part without. I noticed because linker errors where something was @nogc in the root package but not in its dependencies. So in general it just doesn't work to set dip flags in a library config.
There was a problem hiding this comment.
No. Interesting is there a case when the DIP can't be used? I thought it is quite good.
I will create a patch tomorrow.
There was a problem hiding this comment.
To be honest, there probably aren't many practical cases where you can't use it (maybe if you catch and store exceptions?), but nonetheless it does cause quite confusing breakage (because dub and dflags don't work well)
No description provided.