Move template StructImpl into non-template StringMap.Impl to avoid te… #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordlow
force-pushed
the
avoid-StructImpl
branch
3 times, most recently
from
9c1e6a7 to
dc66c16
Compare
|
Ready now. |
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 65 65
Lines 15864 15864
=======================================
Hits 14760 14760
Misses 1104 1104
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mplate-bloat and to avoid the linker bug.
I just copied the
StructImplas is intoStringMap.Impland removed its template parameters and made it static private.Note that GitHub's attempt at presenting the diff is useless.
If you want to double-check the diff manually I suggest you check it manually. But as I said I haven't made any changes to the members of
StructImpl.Ready now.