Don't depend on stringof in mir.parse test
#422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilsonator
approved these changes
Jul 3, 2022
|
Can a new tag be made so buildkite picks it up? |
|
Yes, I'll leave that to @9il |
|
Doesn't v3.14.10 contain this change? |
|
Shortly after this was merged buildkite was still failing, and I was looking at releases and the latest one is from 2020 so I thought nothing changed. But it seems buildkite is green now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocking dlang/dmd#14218
Depending on the specific output of
.stringofis bad practice, like the spec says: