Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: webrtc #264

Merged
merged 19 commits into from
Jan 27, 2023
Merged

feat: webrtc #264

merged 19 commits into from
Jan 27, 2023

Conversation

salmad3
Copy link
Member

@salmad3 salmad3 commented Dec 5, 2022 •
edited
Loading

Context

Latest preview

Please view the latest Fleek preview here.

@salmad3 salmad3 marked this pull request as draft December 5, 2022 12:29
@salmad3 salmad3 added the ready for review PR is ready for review label Dec 5, 2022
@salmad3 salmad3 marked this pull request as ready for review December 5, 2022 17:49
p-shahi
p-shahi reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@p-shahi p-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a general first pass

content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
salmad3 and others added 2 commits December 5, 2022 20:50
@salmad3 @p-shahi
Apply suggestions from code review
a0aebe5 
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
@salmad3
incorporate PR feedback
196958d
@salmad3 salmad3 mentioned this pull request Dec 6, 2022
Open
@salmad3 salmad3 requested a review from p-shahi December 6, 2022 02:02
mxinden
mxinden reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up Danny.

I am not sure what the target audience is here. My intuition tells me that this would be too detailed for a libp2p user.

content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
@salmad3 salmad3 added change request PR requires changes. and removed ready for review PR is ready for review labels Dec 15, 2022
@salmad3 @mxinden
Apply suggestions from code review
24e6faa 
Co-authored-by: Max Inden <mail@max-inden.de>
marten-seemann
marten-seemann previously requested changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure-wise, it would be nice to have the motivation for WebRTC at the top, not at the bottom of the document.

content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
@salmad3 salmad3 added ready for review PR is ready for review and removed change request PR requires changes. labels Dec 15, 2022
@salmad3
Copy link
Member Author

salmad3 commented Dec 15, 2022

thanks @mxinden and @marten-seemann, feedback has been incorporated.

@salmad3 salmad3 mentioned this pull request Dec 21, 2022
Merged
2 tasks
mxinden
mxinden reviewed Jan 4, 2023
View reviewed changes
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
salmad3 and others added 2 commits January 9, 2023 09:58
@salmad3 @mxinden
Apply suggestions from code review
0cb9683 
Co-authored-by: Max Inden <mail@max-inden.de>
@salmad3
rmv duplicate paragraph
5139024
@salmad3 salmad3 requested a review from mxinden January 9, 2023 15:00
@salmad3 @mxinden
Apply suggestions from code review
7ecf79f 
Co-authored-by: Max Inden <mail@max-inden.de>
@salmad3 salmad3 mentioned this pull request Jan 18, 2023
Closed
3 tasks
marten-seemann
marten-seemann reviewed Jan 18, 2023
View reviewed changes
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
marten-seemann
marten-seemann reviewed Jan 24, 2023
View reviewed changes
content/concepts/transports/webrtc.md Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
p-shahi
p-shahi requested changes Jan 24, 2023
View reviewed changes
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
@salmad3 salmad3 added change request PR requires changes. and removed ready for review PR is ready for review labels Jan 24, 2023
p-shahi
p-shahi reviewed Jan 24, 2023
View reviewed changes
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Show resolved Hide resolved
salmad3 and others added 3 commits January 24, 2023 17:03
@salmad3 @p-shahi
Apply suggestions from code review
ef5dd1b 
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
@salmad3 @p-shahi
Apply suggestions from code review
e856b80 
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
@salmad3
incorporate PR feedback; edits, lint, update features with SDP
334eca2
@salmad3 salmad3 requested a review from p-shahi January 24, 2023 22:23
@salmad3 salmad3 added ready for review PR is ready for review and removed change request PR requires changes. labels Jan 24, 2023
p-shahi
p-shahi approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@p-shahi p-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me, the others should approve before merging

content/concepts/transports/webrtc.md Show resolved Hide resolved
@salmad3 salmad3 added the P0 Critical label Jan 26, 2023
mxinden
mxinden approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple of comments. I am in favor of merging here afterwards. Thanks @DannyS03 for the work.

content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
content/concepts/transports/webrtc.md Outdated Show resolved Hide resolved
@salmad3 salmad3 removed the ready for review PR is ready for review label Jan 27, 2023
@salmad3
Copy link
Member Author

salmad3 commented Jan 27, 2023

Thank you for the reviews and efforts folks.

@salmad3 salmad3 dismissed marten-seemann’s stale review January 27, 2023 12:05

review satisfied by mxinden

@salmad3 salmad3 merged commit 65db212 into master Jan 27, 2023
@salmad3 salmad3 deleted the transports/webrtc branch January 27, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-shahi p-shahi p-shahi approved these changes

@mxinden mxinden mxinden approved these changes

@marten-seemann marten-seemann Awaiting requested review from marten-seemann

Assignees
No one assigned
Labels
P0 Critical
Projects
go-libp2p
Archived in project
libp2p Product
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document "WebRTC: Browser to Server"
4 participants
@salmad3 @marten-seemann @mxinden @p-shahi