Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kad-dht #290

Merged
merged 12 commits into from
Feb 10, 2023
Merged

feat: kad-dht #290

merged 12 commits into from
Feb 10, 2023

Conversation

salmad3
Copy link
Member

@salmad3 salmad3 commented Jan 15, 2023

Context

  • Adds general document for Kademila DHT, with the intention to use other sections (i.e. routing and discovery) for more focussed material.

Latest preview

Preview unavailable atm as not against master

@salmad3 salmad3 marked this pull request as draft January 15, 2023 15:42
@salmad3 salmad3 marked this pull request as ready for review January 17, 2023 10:55
@salmad3 salmad3 added the ready for review PR is ready for review label Jan 17, 2023
mxinden
mxinden reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the write-up.

content/concepts/introduction/protocols/dht.md Outdated Show resolved Hide resolved
content/concepts/introduction/protocols/dht.md Outdated Show resolved Hide resolved
content/concepts/introduction/protocols/dht.md Outdated Show resolved Hide resolved
content/concepts/introduction/protocols/dht.md Outdated Show resolved Hide resolved
content/concepts/introduction/protocols/dht.md Outdated Show resolved Hide resolved
content/concepts/introduction/protocols/dht.md Outdated Show resolved Hide resolved
content/concepts/introduction/protocols/dht.md Outdated Show resolved Hide resolved
salmad3 and others added 2 commits January 23, 2023 06:39
@salmad3
Copy link
Member Author

salmad3 commented Jan 23, 2023

thanks for the review @mxinden

@salmad3 salmad3 requested a review from mxinden January 23, 2023 13:35
@salmad3 salmad3 added the P1 High label Jan 26, 2023
@mxinden
Name as result not hash
beb9021
@mxinden
Drop reference to other DHTs
4231b62 
The majority of our implementations is still based on vanilla Kademlia. Thus
mentioning the others might just confuse users.
@mxinden
Drop the "management" of nodes
fe88713
@mxinden
Reword peer and provider routing and remove client/server mode
73747d2 
The latter is an advanced topic. I don't think it is useful for newcomers.
@mxinden
Remove RPC message section
0cc1697 
I would consider this a technical detail not interesting for newcomers.
@mxinden
Stress that the majority of buckets is always empty
61b7011
@mxinden
Typo on prefix length being disproportional to closeness
1b5de71
@mxinden
I would argue all DHTs are build for p2p systems
8bbabcc
mxinden
mxinden approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a couple of updates. This is good to go from my end. Unless there are any objections, I will merge next week.

@p-shahi
Copy link
Member

p-shahi commented Feb 10, 2023

thank you @mxinden !

@p-shahi p-shahi merged commit c1eb2f3 into refactor/intro Feb 10, 2023
@p-shahi p-shahi deleted the protocols/kaddht branch February 10, 2023 15:23
@p-shahi
Copy link
Member

p-shahi commented Feb 10, 2023

This is targetting a refactor/introbranch so I merged it into that, lets aim to merge refactor/intro into master next week

@p-shahi p-shahi mentioned this pull request Mar 1, 2023
Merged
p-shahi pushed a commit that referenced this pull request Mar 1, 2023
@salmad3 @p-shahi
feat: kad-dht (#290)
4c340fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@guseggert guseggert Awaiting requested review from guseggert

Assignees
No one assigned
Labels
P1 High ready for review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salmad3 @p-shahi @mxinden