Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update ping documentation to use pingService #325

Merged
merged 3 commits into from
May 31, 2023
Merged

docs: update ping documentation to use pingService #325

merged 3 commits into from
May 31, 2023

Conversation

stefan1010
Copy link
Contributor

@stefan1010 stefan1010 commented May 23, 2023 •
edited by maschad
Loading

Closes #324

@stefan1010 stefan1010 mentioned this pull request May 23, 2023
Closed
maschad
maschad requested changes May 23, 2023
View reviewed changes
Copy link
Member

@maschad maschad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, appreciate the work. Almost there, just some nits.

content/guides/getting-started/javascript.md Outdated Show resolved Hide resolved
content/guides/getting-started/javascript.md Show resolved Hide resolved
maschad
maschad approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@maschad maschad changed the title docs: using pingService in getting-started javascript docs: update ping documentation to use pingService May 23, 2023
@maschad maschad requested review from salmad3 and p-shahi May 23, 2023 20:05
@p-shahi p-shahi merged commit cd696f5 into libp2p:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@salmad3 salmad3 Awaiting requested review from salmad3

@p-shahi p-shahi Awaiting requested review from p-shahi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

js-libp2p ping-pong - TypeError: node.ping is not a function
3 participants
@stefan1010 @maschad @p-shahi