Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky metrics test #1219

Closed
achingbrain opened this issue May 18, 2022 · 0 comments · Fixed by #1238
Closed

Flaky metrics test #1219

achingbrain opened this issue May 18, 2022 · 0 comments · Fixed by #1238
Labels
good first issue Good issue for new contributors

Comments

@achingbrain
Copy link
Member

This test fails intermittently, it should be fixed:

  1) libp2p.metrics
       should move disconnected peers to the old peers list:

      AssertionError: expected 257 to be at least 512
      + expected - actual

      -257
      +512
@achingbrain achingbrain added the good first issue Good issue for new contributors label May 18, 2022
achingbrain added a commit that referenced this issue Jun 8, 2022
@achingbrain
fix: wait for peer stats to be updated during test
d197842 
The peer stats update interval doesn't always align with the timing
in the test so make sure it's elapsed before asserting on the results.

Fixes #1219
@achingbrain achingbrain mentioned this issue Jun 8, 2022
Merged
wemeetagain pushed a commit that referenced this issue Jun 8, 2022
@achingbrain
fix: wait for peer stats to be updated during test (#1238)
b047268 
The peer stats update interval doesn't always align with the timing
in the test so make sure it's elapsed before asserting on the results.

Fixes #1219
@adamlaska adamlaska mentioned this issue Jul 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wait for peer stats to be updated during test libp2p/js-libp2p
1 participant
@achingbrain