Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gcc crate instead of homegrown hack #4

Merged
merged 1 commit into from
Apr 10, 2016
Merged

Conversation

polachok
Copy link
Collaborator

No description provided.

@mrmonday
Copy link
Contributor

Hi there!

Thank you for your work. A couple of points:

  • Could you use spaces instead of tabs please?
  • This change removes the -Dstatic= -Dinline= hack, which means that the symbols are not exported, so linking will fail

Unrelatedly, we should really get Travis set up so this gets tested automatically.

@polachok
Copy link
Collaborator Author

I pushed an update and added a little test to see if it links.

@polachok
Copy link
Collaborator Author

I'll create a PR for travis when this one is merged (see https://github.com/polachok/netmap_sys/pull/2/files)

@mrmonday
Copy link
Contributor

I'd actually really appreciate it if you could make the pull request for Travis now, since you've done the work! It would mean that this one can be tested properly before merging, which would be great.

Before you do that, could you add:

cache:
    directories:
        - $HOME/.cargo
rust:
    - stable
    - beta
    - nightly
notifications:
    irc:
        channels:
            - "chat.freenode.net#libpnet"
        use_notice: true

In there? Thanks!

@mrmonday
Copy link
Contributor

Great work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants