Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for crashes on "Close Content" #56

Merged
merged 2 commits into from
Jun 13, 2021

Conversation

covey-j
Copy link
Contributor

@covey-j covey-j commented Jun 12, 2021

Workaround that appears to fix most crashes on Close Content on Windows 10 and Xbox. I haven't tested this on Linux.

This is, by no means, a proper fix, as it appears to leave behind a zombie process more frequently when closing Retroarch. A more robust solution is needed in the long run, but for now, I believe this is the lesser of two evils. Some testing results on my end:

In the most recent build before this PR, the Windows 10 build would frequently crash on Close Content or hang when running content after previously closing content, particularly when MTVU was on. The Xbox build would almost always crash or hang when closing content or when loading content after having previously closed content in pcsx2.

With speedhacks enabled and set to the Balanced preset (as to enable MTVU), I tested 21 games on Xbox Series X. In sequence, I managed to boot 20/21 of them to menu, close content, and launch the next game without a single crash or hang. The only game in my testing that failed to close was Jak II, which hung on Close Content. This does not appear to be a regression, since Jak II also hung on Close Content with the previous build.

Some notes:

  1. Restart Content still deadlocks. This workaround doesn't fix that
  2. There appear to be issues with switching from the pcsx2 core to other hardware-rendered cores (e.g. Dolphin). I've seen reports of this on Discord with builds prior to this PR, so I don't believe this is a regression from this workaround. Other cores seem to load just fine after switching from the pcsx2 core

@covey-j covey-j changed the title Workaround for crashes on Close Content Workaround for crashes on "Close Content" Jun 12, 2021
@SeventySixx
Copy link
Contributor

Works great, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants